Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-modern-birthdays upgrade to SPFx 1.20 #5378

Merged

Conversation

a1mery
Copy link
Contributor

@a1mery a1mery commented Jan 19, 2025

  • New sample
  • Bug fix/update
  • Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Sample upgrade to SPFx 1.20.0.

Node version used: v18.18.0

Checklist

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

@hugoabernier hugoabernier merged commit 83de949 into pnp:main Jan 21, 2025
3 checks passed
@hugoabernier
Copy link
Collaborator

Thank you @a1mery for your update! Highly appreciated! Nice to be able to process a PR without having to make any change!

Thank you for sharing your sample with others - you rock! 👏🥇👩‍💻

@a1mery
Copy link
Contributor Author

a1mery commented Jan 21, 2025

Thanks @hugoabernier for those kind words! 🤩
It was actually a secret objective of mine: submitting the perfect PR 💪😉

@a1mery a1mery deleted the react-modern-birthdays-upgrade-to-v1.20 branch January 21, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants